Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: support instanceName filtering for kubernetes auto-discovery deployment #2488

Merged
merged 4 commits into from
Dec 17, 2023
Merged

Enhancement: support instanceName filtering for kubernetes auto-discovery deployment #2488

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6b2f7f
Update service-helpers.js
atropos112 Dec 17, 2023
5c2aa4e
Documentation and cleanup
atropos112 Dec 17, 2023
a18272d
Update docs/configs/kubernetes.md
atropos112 Dec 17, 2023
4e3d20e
Update kubernetes.md
shamoon Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/utils/config/service-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ export async function checkCRD(kc, name) {
export async function servicesFromKubernetes() {
const ANNOTATION_BASE = "gethomepage.dev";
const ANNOTATION_WIDGET_BASE = `${ANNOTATION_BASE}/widget.`;

const { instanceName } = getSettings();

checkAndCopyConfig("kubernetes.yaml");

try {
Expand Down Expand Up @@ -238,7 +239,7 @@ export async function servicesFromKubernetes() {
const services = ingressList.items
.filter(
(ingress) =>
ingress.metadata.annotations && ingress.metadata.annotations[`${ANNOTATION_BASE}/enabled`] === "true",
ingress.metadata.annotations && ingress.metadata.annotations[`${ANNOTATION_BASE}/enabled`] === "true" && (!ingress.metadata.annotations[`${ANNOTATION_BASE}/instance`] || ingress.metadata.annotations[`${ANNOTATION_BASE}/instance`] === instanceName),
)
.map((ingress) => {
let constructedService = {
Expand Down
Loading