Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: configurable CPU temp scale #3332

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

daviddavid
Copy link
Contributor

@daviddavid daviddavid commented Apr 19, 2024

Proposed change

Introduces tempmin and tempmax in resources/cputemp.jsx as optional parameters to configure the CPU temperature scale. By default, if no values are provided, the existing heuristic is used (scale from 0 to highest core temp). If tempmin and/or tempmax are set, the scale will be adjusted accordingly. This allows for a more meaningful scale, that isn't always at 99% for most use cases.

Closes #2478

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon enabled auto-merge (squash) April 19, 2024 23:29
@shamoon shamoon disabled auto-merge April 19, 2024 23:29
@shamoon shamoon enabled auto-merge (squash) April 19, 2024 23:30
@shamoon shamoon changed the title Feature: configurable CPU temp scale Enhancement: configurable CPU temp scale Apr 19, 2024
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks

@shamoon shamoon merged commit c95837f into gethomepage:main Apr 19, 2024
5 checks passed
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request May 6, 2024
… v0.8.13 ) (#3607)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.12` -> `v0.8.13` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.13`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.13)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.12...v0.8.13)

#### What's Changed

- Enhancement: configurable CPU temp scale by
[@&#8203;daviddavid](https://togithub.com/daviddavid) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3332
- Enhancement: additional tautulli jellyfin emby configuration options
by [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) in
[gethomepage/homepage#3350
- Enhancement: add bitrate precision config option for speedtest-tracker
by [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3354
- Fix: format Romm statistics by
[@&#8203;EdwardSalter](https://togithub.com/EdwardSalter) in
[gethomepage/homepage#3358
- Fix some unsanitized error URLs by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3385
- Chore(deps): Bump recharts from 2.12.3 to 2.12.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3397
- Chore(deps-dev): Bump typescript from 4.9.5 to 5.4.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3396
- Chore(deps): Bump systeminformation from 5.22.0 to 5.22.7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3398
- Chore(deps): Bump react from 18.2.0 to 18.3.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3400
- Chore(deps-dev): Bump eslint-config-next from 12.3.4 to 14.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3399

#### New Contributors

- [@&#8203;daviddavid](https://togithub.com/daviddavid) made their first
contribution in
[gethomepage/homepage#3332
- [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) made their
first contribution in
[gethomepage/homepage#3350
- [@&#8203;EdwardSalter](https://togithub.com/EdwardSalter) made their
first contribution in
[gethomepage/homepage#3358

**Full Changelog**:
gethomepage/homepage@v0.8.12...v0.8.13

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDIuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM0Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
truecharts-admin added a commit to truecharts/charts that referenced this pull request May 6, 2024
…0.8.13@43a3ee8 by renovate (#21685)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.12` -> `v0.8.13` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.13`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.13)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.12...v0.8.13)

#### What's Changed

- Enhancement: configurable CPU temp scale by
[@&#8203;daviddavid](https://togithub.com/daviddavid) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3332
- Enhancement: additional tautulli jellyfin emby configuration options
by [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) in
[gethomepage/homepage#3350
- Enhancement: add bitrate precision config option for speedtest-tracker
by [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3354
- Fix: format Romm statistics by
[@&#8203;EdwardSalter](https://togithub.com/EdwardSalter) in
[gethomepage/homepage#3358
- Fix some unsanitized error URLs by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3385
- Chore(deps): Bump recharts from 2.12.3 to 2.12.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3397
- Chore(deps-dev): Bump typescript from 4.9.5 to 5.4.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3396
- Chore(deps): Bump systeminformation from 5.22.0 to 5.22.7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3398
- Chore(deps): Bump react from 18.2.0 to 18.3.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3400
- Chore(deps-dev): Bump eslint-config-next from 12.3.4 to 14.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3399

#### New Contributors

- [@&#8203;daviddavid](https://togithub.com/daviddavid) made their first
contribution in
[gethomepage/homepage#3332
- [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) made their
first contribution in
[gethomepage/homepage#3350
- [@&#8203;EdwardSalter](https://togithub.com/EdwardSalter) made their
first contribution in
[gethomepage/homepage#3358

**Full Changelog**:
gethomepage/homepage@v0.8.12...v0.8.13

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM0My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
github-merge-queue bot pushed a commit to chezmoi-sh/atlas that referenced this pull request May 19, 2024
…114)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change | OpenSSF |
|---|---|---|---|
| [gethomepage/homepage](https://togithub.com/gethomepage/homepage) |
patch | `v0.8.12` -> `v0.8.13` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/gethomepage/homepage/badge)](https://securityscorecards.dev/viewer/?uri=github.com/gethomepage/homepage)
|

---

### Release Notes

<details>
<summary>gethomepage/homepage (gethomepage/homepage)</summary>

###
[`v0.8.13`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.13)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.12...v0.8.13)

##### What's Changed

- Enhancement: configurable CPU temp scale by
[@&#8203;daviddavid](https://togithub.com/daviddavid) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3332
- Enhancement: additional tautulli jellyfin emby configuration options
by [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) in
[gethomepage/homepage#3350
- Enhancement: add bitrate precision config option for speedtest-tracker
by [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3354
- Fix: format Romm statistics by
[@&#8203;EdwardSalter](https://togithub.com/EdwardSalter) in
[gethomepage/homepage#3358
- Fix some unsanitized error URLs by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3385
- Chore(deps): Bump recharts from 2.12.3 to 2.12.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3397
- Chore(deps-dev): Bump typescript from 4.9.5 to 5.4.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3396
- Chore(deps): Bump systeminformation from 5.22.0 to 5.22.7 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3398
- Chore(deps): Bump react from 18.2.0 to 18.3.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3400
- Chore(deps-dev): Bump eslint-config-next from 12.3.4 to 14.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[gethomepage/homepage#3399

##### New Contributors

- [@&#8203;daviddavid](https://togithub.com/daviddavid) made their first
contribution in
[gethomepage/homepage#3332
- [@&#8203;ameerabdallah](https://togithub.com/ameerabdallah) made their
first contribution in
[gethomepage/homepage#3350
- [@&#8203;EdwardSalter](https://togithub.com/EdwardSalter) made their
first contribution in
[gethomepage/homepage#3358

**Full Changelog**:
gethomepage/homepage@v0.8.12...v0.8.13

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/chezmoi-sh/WIP-monorepo).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants