Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing image #3

Closed
TehShrike opened this issue Nov 16, 2013 · 4 comments
Closed

Missing image #3

TehShrike opened this issue Nov 16, 2013 · 4 comments
Assignees
@getify
Labels
enhancement

Comments

@TehShrike
Copy link

Not sure if this is a product of still being in draft form, or if a file got missed in a commit - https://github.com/getify/You-Dont-Know-JS/blob/master/scope%20%26%20closure/ch1.md#building-on-metaphors references ./fig1.png, which doesn't exist at the moment.
@getify
Copy link
Owner

getify commented Nov 16, 2013

Correct, none of the figures are created yet. Still TODO. :)

@hemanth
Copy link

hemanth commented Nov 18, 2013

@TehShrike Came here to report the same 👍

@ghost ghost assigned getify Dec 24, 2013
@bmacdonald-editor bmacdonald-editor mentioned this issue Jan 7, 2014
Closed
@ghost ghost mentioned this issue Jan 23, 2014
Closed
@getify getify closed this as completed Feb 8, 2014
@getify
Copy link
Owner

getify commented Feb 8, 2014

images for chapters 1 and 2 have been added now.

@hemanth
Copy link

hemanth commented Feb 8, 2014

👍

@ddijk ddijk mentioned this issue Jan 20, 2018
Closed
gitbook-com bot pushed a commit to tlqhrm/You-Dont-Know-JS that referenced this issue Nov 8, 2022
@gitbook-bot
GitBook: [getify#3] No subject
5ca7210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getify getify

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hemanth @getify @TehShrike