Added support for kedro namespaces for parameters #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now params which defined as `outer_namespace.inner_namespace.param_name` converted to the following structure before adding to pipeline:
```json
{
"outer_namespace": {
"inner_namespace": {
"param_name": "value",
...
},
"another_inner_namespace": {
"param_name": "value"
...
}
}
}
```
Added support for kedro namespaces for parameters
Now params which defined as `outer_namespace.inner_namespace.param_name` converted to the following structure before adding to pipeline:
```json
{
"outer_namespace": {
"inner_namespace": {
"param_name": "value",
...
},
"another_inner_namespace": {
"param_name": "value"
...
}
}
}
```
|
Looks great, @DmitriyLamzin! Thanks for your contribution |
|
Looks like CI is broken. I don't think my changes could break it. |
|
@DmitriyLamzin You're right, the CI is broken, I have the fix ready, and we will merge it on Monday. |
Closed
szczeles
approved these changes
Feb 27, 2023
|
@DmitriyLamzin Released as 0.7.4 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now params which defined as
outer_namespace.inner_namespace.param_nameare converted to the following structure before adding to the pipeline:{ "outer_namespace": { "inner_namespace": { "param_name": "value", ... }, "another_inner_namespace": { "param_name": "value" ... } } }Description
describe the purpose of the change hereResolves #219
PR Checklist