New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #682: Support postman import schema v2.1.0 #1233

Merged
merged 1 commit into from Oct 27, 2018

Conversation

Projects
None yet
2 participants
@coderjoe
Contributor

coderjoe commented Oct 27, 2018

This PR implements support for postman import schema v2.1.0 to the same extent that v2.0.0 was supported. Most notably this means that authentication parameters still are not imported for either version.

Closes #682

@welcome

This comment has been minimized.

welcome bot commented Oct 27, 2018

💖 Thanks for opening this pull request! 💖

To help make this a smooth process, please be sure you have first read the
contributing guidelines.

@coderjoe

This comment has been minimized.

Contributor

coderjoe commented Oct 27, 2018

If this PR is considered OK I'd like to take a stab at adding support for importing some of the authentication parameters from Postman imports (both v2.0 and v2.1)

@gschier

This comment has been minimized.

Collaborator

gschier commented Oct 27, 2018

Oh wow, it looks like not much changed between 2.0 and 2.1. Perhaps things were changed/added that we don't support yet? Either way, this looks awesome, thanks for doing it! 💯

@gschier

This comment has been minimized.

Collaborator

gschier commented Oct 27, 2018

And yes, please go ahead and extend support where needed. I'm sure A LOT of people will appreciate the improvements

@gschier gschier merged commit 65a08a2 into getinsomnia:develop Oct 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 27, 2018

Congrats on merging your first pull request! 🎉🎉🎉 You're helping make Insomnia awesome! 🙌

@coderjoe coderjoe deleted the coderjoe:feature/postman-import-v2.1 branch Oct 27, 2018

@coderjoe

This comment has been minimized.

Contributor

coderjoe commented Oct 31, 2018

@gschier per your suggestion I've added support for all of the auth methods that I use both personally and at work. It isn't all all of the authorization methods supported by Postman, but it is most of them. You'll find them in PR #1244 .

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment