-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forced use of mootool by calling JHTMLbehavior::modal on all items views #21
Comments
Hi. Unfortunately the Joomla! modal is required for front-end editing. The check that is there checks three things:
If none of the above is true, then you should not get the modal loaded in your page. |
I don't think that this logic is proper : 1- test if the user is not a guest is not sufficient, for example on a 2- if a K2 site, use bootstrap modal, or any other modal mechanism (e.g or controlled by this define flag of yours. 3- same for any lightbox image In my case, I was able to inject bootstrap and jQuery, long before Joomla I don't think that I'm alone trying this I'm the Joomla 2.5 path. On Tue, Sep 10, 2013 at 3:29 PM, Lefteris Kavadas
|
I don't disagree in total with you but there are somethings to consider:
To summarize i do agree with you that we need to cut off mootools completely, but doing this now will generate a lot of confusion to the users and will make current sites look broken. |
I understand that very well Could it be possible to introduce a new constant and a logic shortcut, that A first though the already referred constant was about that, and it is not Regards On Tue, Sep 10, 2013 at 5:34 PM, Lefteris Kavadas
|
An option in K2 paramaters is a possible solution, but this is something i cannot decide on my own. I need to talk with the rest members of the team. |
The Joomla modal will be removed for non editing features in K2 2.7.0 thus resolving this issue. |
would be perfect !!!! Thanks in advance. |
I'm trying to remove all links to mootools in a 2.5 version of a site.
Succeeded so far until I get into those lines in K2 Plug-in on the AfterRoute method
if ( !$user->guest || (JRequest::getCmd('option') == 'com_k2' && JRequest::getCmd('view') == 'item') || defined('K2_JOOMLA_MODAL_REQUIRED') ){
JHTML::_('behavior.modal');
}
I don't understand why, you'd force use of this mootool modal, for example on people that use other modals (NoNumber modal come to mind).
Could there be a better way to use this K2 constant K2_JOOMLA_MODAL_REQUIRED ?
In front of this if statement an create a more meaningful logic shortcut along something like 👍
if ( defined('K2_JOOMLA_MODAL_REQUIRED') && ....
note : this kinda duplicate of tickets 68 and 582 on google issues.
The text was updated successfully, but these errors were encountered: