Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check if thumbnail was created #1788

Closed
mullema opened this issue May 18, 2019 · 3 comments
Closed

No check if thumbnail was created #1788

mullema opened this issue May 18, 2019 · 3 comments
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@mullema
Copy link
Contributor

mullema commented May 18, 2019

On my shared hosting the allowed number of processes is limited. I haven't had a problem until I switched the image driver to imagemagick.

I have a files section with 50 big images. When I open that panel page the first time thumbnails should be created. With the limits on my hosting only 8 of them get created. Nevertheless the other images show up aswell but are loaded in full size.

In the thumbs component the source image is copied with the intended thumbnail name to the media folder before thumbnail processes are started.

When looking at running processes and their output I can see that the convert processes are not started or end with exit code NULL. This is actually caught here in the ImageMagick Class. The error is not further handled in the thumb process though.

A file with the intended thumb name exists and the job file gets removed no matter what happened in the thumbs component.

From now on Kirby assumes that this thumbnail was created and serves the file in the media folder. But it is actually just a copy of the source file.
As long as I don't clear the media cache I will always get the source file in full size when requesting that thumbnail.

To serve the source file instead of the thumbnail seems like a good way to handle an error in thumb creation.

Expected behavior
But Kirby could still try again to create the thumbnail with the next request.

Kirby Version
3.1.3

@mullema mullema changed the title No check if thumb was created No check if thumbnail was created May 18, 2019
@bastianallgeier bastianallgeier added the type: bug 🐛 Is a bug; fixes a bug label May 28, 2019
@distantnative distantnative added this to the 3.2.1 milestone May 28, 2019
@bastianallgeier bastianallgeier modified the milestones: 3.2.1, 3.2.0 Jun 7, 2019
@bastianallgeier
Copy link
Member

@silllli
Copy link
Contributor

silllli commented Oct 16, 2020

I still experience this problem with version 3.4.3: shared hosting with a limited process amount and according to a notification in the hosting management software, the process limit was hit again and again. This results in thumbnail files that appear to be simple copies of the original.

@afbora
Copy link
Member

afbora commented Dec 21, 2020

Moved to #3023

@afbora afbora closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

No branches or pull requests

5 participants