You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On my shared hosting the allowed number of processes is limited. I haven't had a problem until I switched the image driver to imagemagick.
I have a files section with 50 big images. When I open that panel page the first time thumbnails should be created. With the limits on my hosting only 8 of them get created. Nevertheless the other images show up aswell but are loaded in full size.
In the thumbs component the source image is copied with the intended thumbnail name to the media folder before thumbnail processes are started.
When looking at running processes and their output I can see that the convert processes are not started or end with exit code NULL. This is actually caught here in the ImageMagick Class. The error is not further handled in the thumb process though.
A file with the intended thumb name exists and the job file gets removed no matter what happened in the thumbs component.
From now on Kirby assumes that this thumbnail was created and serves the file in the media folder. But it is actually just a copy of the source file.
As long as I don't clear the media cache I will always get the source file in full size when requesting that thumbnail.
To serve the source file instead of the thumbnail seems like a good way to handle an error in thumb creation.
Expected behavior
But Kirby could still try again to create the thumbnail with the next request.
Kirby Version
3.1.3
The text was updated successfully, but these errors were encountered:
mullema
changed the title
No check if thumb was created
No check if thumbnail was created
May 18, 2019
I still experience this problem with version 3.4.3: shared hosting with a limited process amount and according to a notification in the hosting management software, the process limit was hit again and again. This results in thumbnail files that appear to be simple copies of the original.
On my shared hosting the allowed number of processes is limited. I haven't had a problem until I switched the image driver to imagemagick.
I have a files section with 50 big images. When I open that panel page the first time thumbnails should be created. With the limits on my hosting only 8 of them get created. Nevertheless the other images show up aswell but are loaded in full size.
In the thumbs component the source image is copied with the intended thumbnail name to the media folder before thumbnail processes are started.
When looking at running processes and their output I can see that the
convert
processes are not started or end with exit code NULL. This is actually caught here in the ImageMagick Class. The error is not further handled in the thumb process though.A file with the intended thumb name exists and the job file gets removed no matter what happened in the thumbs component.
From now on Kirby assumes that this thumbnail was created and serves the file in the media folder. But it is actually just a copy of the source file.
As long as I don't clear the media cache I will always get the source file in full size when requesting that thumbnail.
To serve the source file instead of the thumbnail seems like a good way to handle an error in thumb creation.
Expected behavior
But Kirby could still try again to create the thumbnail with the next request.
Kirby Version
3.1.3
The text was updated successfully, but these errors were encountered: