Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Infinite reload with Custom Block Selector Plugin installed #5263

Closed
tobimori opened this issue Jun 10, 2023 · 8 comments · Fixed by #5264
Closed

[v4] Infinite reload with Custom Block Selector Plugin installed #5263

tobimori opened this issue Jun 10, 2023 · 8 comments · Fixed by #5264
Assignees
Labels
type: regression 🚨 Is a regression between versions
Milestone

Comments

@tobimori
Copy link
Contributor

Description

With the Kirby Visual Block Selector Plugin installed, the panel reloads indefinitely.

To reproduce

Install Kirby 4 Beta & the linked plugin above.

Your setup

Kirby Version v4.0.0-alpha.2

@lukasbestle lukasbestle added the type: regression 🚨 Is a regression between versions label Jun 10, 2023
@lukasbestle lukasbestle added this to the 4.0.0 milestone Jun 10, 2023
@distantnative
Copy link
Member

Cannot reproduce this. Works fine for me with alpha.2:
Screenshot 2023-06-10 at 11 31 27

@distantnative distantnative added the needs: replication 🔬 Requires a sample to reproduce the issue label Jun 10, 2023
@medienbaecker
Copy link
Contributor

I also use this plugin in a v4 installation without issues.

@tobimori
Copy link
Contributor Author

hm. i'll check if I can reproduce it again.

@tobimori
Copy link
Contributor Author

tobimori commented Jun 10, 2023

Tries to access the API route on the Login site already and fails with "401 Unauthorized", then reloads, tries again. Works when already logged in. I can't remember having this issue on Kirby 3.9.4 installations, can you check again? I assume it's related to changes in the plugin registry.

@distantnative distantnative self-assigned this Jun 10, 2023
@distantnative distantnative removed the needs: replication 🔬 Requires a sample to reproduce the issue label Jun 10, 2023
@distantnative
Copy link
Member

distantnative commented Jun 10, 2023

Could reproduce.

I have suggested one change to the core (trying to avoid unauthenticated endless loops), but also the plugin needs to add a small change for v4 (junohamburg/kirby-visual-block-selector#2).

@distantnative distantnative linked a pull request Jun 10, 2023 that will close this issue
@distantnative distantnative modified the milestones: 4.0.0, 4.0.0-alpha.3 Jun 10, 2023
@SebastianEberlein-JUNO
Copy link

We just released a new version with a fix: https://github.com/junohamburg/kirby-visual-block-selector/releases/tag/1.1.1

@distantnative
Copy link
Member

@bastianallgeier I think this isn't fixed just because the plugin circumvents it now. We should fix this in the core too

@distantnative distantnative reopened this Jun 12, 2023
@bastianallgeier
Copy link
Member

@distantnative Ok, you are right. I saw your PR afterwards. Then it should be fixed now on our side as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression 🚨 Is a regression between versions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants