Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No redirect to logout when already logged out #5264

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

distantnative
Copy link
Member

Avoid redirect loops

@bastianallgeier not sure if the second part is a correct fix to our blank error dialogs issue

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Jun 10, 2023
@distantnative distantnative added this to the 4.0.0-alpha.3 milestone Jun 10, 2023
@distantnative distantnative self-assigned this Jun 10, 2023
@distantnative distantnative linked an issue Jun 10, 2023 that may be closed by this pull request
@bastianallgeier
Copy link
Member

@distantnative I think we could potentially lose stuff in the error object this way. I.e. the code.

@distantnative
Copy link
Member Author

But without it our panel shows empty dialogs etc. it doesn’t seem able to handle actual error instances

Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at it again, and we might indeed find out that we miss keys from the object later. But it's no problem to add them here.

@bastianallgeier bastianallgeier merged commit 1f77b6f into v4/develop Jun 12, 2023
@bastianallgeier bastianallgeier deleted the v4/fix/5263-logout-redirect branch June 12, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4] Infinite reload with Custom Block Selector Plugin installed
2 participants