-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken page list in "move page" and "select page" widgets (server error) #6020
Comments
Alright, I found the issue. Using XDebug, I found where the error was generated: Lines 115 to 120 in 40eae8e
The issue was that I had one page blueprint ( title: Error page
image: false
sections:
fields:
# … This faulty value (probably the result of writing blueprints through a lot of trial and error ^^) gets returned as-is by So this is definitely my fault and not a bug per se, but this was very hard to identify. Could something be improved here? There is some blueprint data normalization going on here, maybe there should be more? Lines 74 to 84 in 40eae8e
|
By the way I checked the cookbook (because earlier in the year I had copied page blueprint examples from the cookbook that were triggering bugs in Kirby 3.9, so I was wondering if that was from a faulty example). Couldn't find an instance of |
Will need look into this as these lines Lines 101 to 104 in 40eae8e
|
Got it, it's not the |
Description
I’m testing an update of a 3.9 site to 4.0 and it looks like the page list widget used in a few places, namely in the "Move page" dialog and in the page selection widget of the Retour for Kirby plugin, breaks with a server error:
Some URLs for GET requests from the Panel that show this exact error:
http://localhost:8000/panel/site/tree?parent=%2Fsite
http://localhost:8000/panel/site/tree?move=%2Fpages%2Fcontact&parent=%2Fsite
Expected behavior
The request to
/panel/site/tree
doesn't fail.Screenshots
To reproduce
I don't have steps to reproduce or a minimal reproduction yet.
I understand this is very little information to go with, and I suspect it's something in my setup (otherwise there would be issues for this filed already). I’m not confident I can make a simple repro through trial and error.
Any pointers on how I could investigate this?
I have
'debug' => true, 'whoops' => true
in my config, but those Panel API requests don't show more information about where the issue occurred.Your setup
Kirby Version
4.0.0
Console output
See above for the failing API request. There's another JS error after that, which I suspect comes from not handling the error response from the API when rendering the UI.
Your system (please complete the following information)
The text was updated successfully, but these errors were encountered: