Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps code splitting with Vite 3 #4504

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 14, 2022

This PR …

Enhancements

  • Reduced size of the Panel's vendor JS file by adding code splitting for the vuedraggable.js library

Before

dist/css/style.css   106.29 KiB / gzip: 18.02 KiB
dist/js/index.js     303.70 KiB / gzip: 71.99 KiB
dist/js/vendor.js    375.31 KiB / gzip: 120.69 KiB

After

dist/js/vuedraggable.js   40.74 KiB / gzip: 14.12 KiB 
dist/css/style.css        106.29 KiB / gzip: 18.01 KiB
dist/js/index.js          304.26 KiB / gzip: 72.29 KiB
dist/js/vendor.js         333.99 KiB / gzip: 106.81 KiB

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jul 14, 2022
@distantnative distantnative self-assigned this Jul 14, 2022
@distantnative distantnative force-pushed the feature/code-splitting-vite-3 branch 2 times, most recently from 3d43e87 to aca16c1 Compare July 22, 2022 13:42
@distantnative distantnative added the needs: decision 🗳 Requires a decision to proceed label Aug 3, 2022
@distantnative distantnative removed the needs: decision 🗳 Requires a decision to proceed label Aug 4, 2022
@distantnative distantnative marked this pull request as ready for review August 4, 2022 11:30
@distantnative distantnative added this to the 3.7.3 milestone Aug 4, 2022
@distantnative distantnative requested review from afbora and a team August 4, 2022 12:03
@distantnative
Copy link
Member Author

@afbora did my previous changes cause the problem you just fixed? and we probably should recompile list files then again.

@afbora
Copy link
Member

afbora commented Aug 5, 2022

Yes, email mark was throwing error because of email mark has not the editor payload.

@afbora
Copy link
Member

afbora commented Aug 5, 2022

Btw are we sure that want to move this changes to 3.7.3? I would favor of 3.7.4 since we already publish releases in short cycles.

@bastianallgeier bastianallgeier modified the milestones: 3.7.3, 3.7.4 Aug 10, 2022
@afbora afbora merged commit e348aad into develop Aug 12, 2022
@afbora afbora deleted the feature/code-splitting-vite-3 branch August 12, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants