-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First steps code splitting with Vite 3 #4504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d43e87
to
aca16c1
Compare
aca16c1
to
05f0ebc
Compare
05f0ebc
to
0b9a596
Compare
0b9a596
to
5a537cb
Compare
@afbora did my previous changes cause the problem you just fixed? and we probably should recompile list files then again. |
Yes, email mark was throwing error because of email mark has not the editor payload. |
afbora
reviewed
Aug 5, 2022
afbora
approved these changes
Aug 5, 2022
Btw are we sure that want to move this changes to 3.7.3? I would favor of 3.7.4 since we already publish releases in short cycles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Enhancements
Before
After
Ready?
Unit tests for fixed bug/featureIn-code documentation (wherever needed)For review team
Add to website docs release checklist (if needed)