F::move(): Support non-atomic moves
#5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasbestle
force-pushed
the
fix/5024-move-tmp
branch
from
0674a20
to
480f1f1
Compare
lukasbestle
changed the title
F::move(): Accept non-atomic operationsF::move(): Support non-atomic moves
bastianallgeier
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
I haven't tested it, but the code comments and tests look good to me. You can merge it unless you want another look from @distantnative or @afbora
afbora
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Fixes
F::move()now detects if the source and target are on different filesystems; it then copies the file and deletes the source on success instead of atomically moving the fileF::move(): Support non-atomic moves #5124Ready?
For review team
Add to website docs release checklist (if needed)