Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

field.isVisible(): fix if statement #6098

Merged
merged 1 commit into from
Dec 30, 2023
Merged

field.isVisible(): fix if statement #6098

merged 1 commit into from
Dec 30, 2023

Conversation

distantnative
Copy link
Member

condition === [] would always be false as JavaScript compares arrays/objects by reference not value

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Dec 29, 2023
@distantnative distantnative added this to the 4.1.0 milestone Dec 29, 2023
@distantnative distantnative requested a review from a team December 29, 2023 18:20
@distantnative distantnative self-assigned this Dec 29, 2023
@bastianallgeier bastianallgeier merged commit 38f5c94 into develop-minor Dec 30, 2023
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/js-field-isVisible branch December 30, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier