Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instanceof Vue #6100

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Replace instanceof Vue #6100

merged 2 commits into from
Jan 8, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Dec 30, 2023 •
edited
Loading

Vue 3 hates instanceof Vue. So already trying to find alternatives.

What I mean by "hates":

vue3.mov

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Dec 30, 2023
@distantnative distantnative added this to the 4.1.0 milestone Dec 30, 2023
@distantnative distantnative requested a review from a team December 30, 2023 11:27
@distantnative distantnative self-assigned this Dec 30, 2023
@distantnative distantnative added the needs: decision 🗳 Requires a decision to proceed label Dec 30, 2023
@distantnative distantnative removed the needs: decision 🗳 Requires a decision to proceed label Jan 1, 2024
@distantnative distantnative changed the title isVueComponent helper Replace instanceof Vue Jan 1, 2024
bastianallgeier
bastianallgeier approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's perfect!

@bastianallgeier bastianallgeier merged commit 3b63960 into develop-minor Jan 8, 2024
13 checks passed
@bastianallgeier bastianallgeier deleted the refactor/is-vue-component branch January 8, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier