Fix nodeInputRule
#6385
Merged
Fix nodeInputRule
#6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
fix/editor-hr-input-rule
branch
from
cc4b06e
to
44f6064
Compare
bastianallgeier
approved these changes
Apr 23, 2024
|
I've added a hr example to the writer field page blueprint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
For the purpose of the hr node,
nodeInputRulealso deleted the previous character before the match (to remove the extra leftover empty line). This behavior doesn't make sense for other nodes, in particular inline nodes. This PR fixes the behavior ofnodeInputRuleand adds the custom behavior directly to the hr node.Fixes
nodeInputRuleonly overwrites matched selectionFor review team