Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server allowlist #6415

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Apr 27, 2024

This PR …

  • Do we want to display the full server name in the Panel now or do we still want to clean it up?
Screenshot 2024-04-27 at 12 47 00

Enhancement

Docs

  • Remove hard server requirements in favor of something like

    Apache works out of the box, nginx and Caddy work with our cookbook recipes and other servers can be used by advanced users

  • Remove servers option

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Apr 27, 2024
@distantnative distantnative added this to the 4.3.0 milestone Apr 27, 2024
@distantnative distantnative requested a review from a team April 27, 2024 10:49
@distantnative distantnative self-assigned this Apr 27, 2024
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to display the full server name in the Panel now or do we still want to clean it up?

Since SERVER_SOFTWARE is an environment variable, it can be set to whatever value. I briefly looked for standards, but it seems like there is none. So we cannot expect the value to be set in a uniform way. For debugging it may actually be useful to have access to the full string including version, so I think we could keep it like this.

tests/Cms/Api/routes/SystemRoutesTest.php Outdated Show resolved Hide resolved
tests/Panel/Areas/InstallationTest.php Show resolved Hide resolved
tests/Cms/System/SystemTest.php Outdated Show resolved Hide resolved
@distantnative distantnative merged commit 065b695 into develop-minor Apr 28, 2024
12 checks passed
@distantnative distantnative deleted the enhancement/remove-server-allowlist branch April 28, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants