Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY button props #6417

Merged
merged 1 commit into from
Apr 29, 2024
Merged

DRY button props #6417

merged 1 commit into from
Apr 29, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Apr 27, 2024 •
edited by bastianallgeier
Loading

This PR …

Enhancement

  • New download prop for k-link (and respective k-button when passing a link) to set the download attribute

Refactored

  • Reusing link and button props in higher-up components

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Apr 27, 2024
@distantnative distantnative added this to the 4.3.0 milestone Apr 27, 2024
@distantnative distantnative requested a review from a team April 27, 2024 16:41
@distantnative distantnative self-assigned this Apr 27, 2024
@distantnative distantnative mentioned this pull request Apr 27, 2024
Closed
7 tasks
bastianallgeier
bastianallgeier approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great little clean-up project.

@bastianallgeier bastianallgeier merged commit b00a705 into develop-minor Apr 29, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the refactor/button-props branch April 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier