Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language view buttons (incl. permission check) #6646

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Language view buttons (incl. permission check) #6646

merged 3 commits into from
Sep 12, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 29, 2024 •
edited
Loading

Description

Summary of changes

  • Renamed k-languages-view-button to k-content-translations-view-button
  • Added dedicated LanguageAddButton, LanguageDeleteButton and LanguageSettingsButton classes
  • Incorporating permissions check for disabled state
  • Fixing LanguageConversionTest after merging 4.3.1 with stricter language permission checks

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

@distantnative distantnative self-assigned this Aug 29, 2024
@distantnative distantnative added this to the 5.0.0-alpha.3 milestone Aug 29, 2024
@distantnative distantnative added type: enhancement ✨ Suggests an enhancement; improves Kirby type: regression 🚨 Is a regression between versions labels Aug 29, 2024
@distantnative distantnative marked this pull request as ready for review August 29, 2024 16:18
@afbora afbora mentioned this pull request Aug 30, 2024
Closed
bastianallgeier
bastianallgeier reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love the button classes. Don't get my inline comments wrong. I really see that we often are not super consistent between model method names and UI routes and components. I just really want to understand why you made the naming decisions.

config/areas/languages/buttons.php Show resolved Hide resolved
config/areas/site/buttons.php Outdated Show resolved Hide resolved
@distantnative distantnative merged commit 8407d88 into v5/develop Sep 12, 2024
12 of 13 checks passed
@distantnative distantnative deleted the v5/fix/language-buttons branch September 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbestle lukasbestle Awaiting requested review from lukasbestle

@afbora afbora Awaiting requested review from afbora

@bastianallgeier bastianallgeier Awaiting requested review from bastianallgeier

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby type: regression 🚨 Is a regression between versions
Projects
None yet
Milestone
5.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier