move effect command from member type to type parameter #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
commented
May 12, 2024
| @@ -10,6 +10,7 @@ val compilerOptions = Seq( | |||
| "-feature", | |||
| "-unchecked", | |||
| "-deprecation", | |||
| "-Ykind-projector", | |||
There was a problem hiding this comment.
To make it easier to define commands.
fwbrasil
commented
May 12, 2024
| @@ -54,3 +49,12 @@ object Vars: | |||
| def run[V >: Nothing]: RunDsl[V] = new RunDsl[V] | |||
|
|
|||
| end Vars | |||
|
|
|||
| // Moving to Vars.internal crashes the compiler | |||
There was a problem hiding this comment.
I get a cyclic type error for Flat if I do this, which doesn't make much sense. It seems a compiler bug.
|
I'm merging this to unblock other work but please feel free to provide feedback! |
|
FYI This change introduced other complexities and didn't fully solve the variance issue. I've reverted it on main. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a follow up of #348 to rely on the new
TaginAborts. Something that has been challenging when developing effects is dealing with variance and theCommanddefined as type member:This fails to compile because
Vis contravariant and type members are invariant. It's possible to work it around by makingCommandopaque but then it's necessary to provide bridge methods.This PR changes the encoding of effects to use a type parameter for the command instead of a type member, which solves this encoding issue with variance.