Switch to using gonat instead of ipproxy #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hwh33
reviewed
May 28, 2019
hwh33
reviewed
May 28, 2019
client.go
Outdated
| sleepTime := 50 * time.Millisecond | ||
| maxSleepTime := f.idleTimeout | ||
|
|
||
| firstDial := true | ||
| writeLoop: |
There was a problem hiding this comment.
Since there is no loop nesting here, why name this loop?
There was a problem hiding this comment.
I think at one point I might have had a nested loop. This function is too long, I'll factor out the substantial portion of the dialing code into its own function and remove the loop label.
hwh33
reviewed
May 28, 2019
|
@hwh33 I've pushed my code review changes |
hwh33
reviewed
May 29, 2019
hwh33
reviewed
May 29, 2019
|
Thanks @hwh33! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of terminating client connections at the packetforward proxy, but using gonat we now simply pass packets through to the upstream origin, performing NAT in the process. This should reduce memory usage and hopefully improve performance/stability.