Updated to latest packetforward #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwh33
reviewed
May 22, 2019
hwh33
reviewed
May 22, 2019
oxtoacart
commented
May 31, 2019
| @@ -583,7 +583,9 @@ func TestDirectOK(t *testing.T) { | |||
| if !assert.NoError(t, err) { | |||
| t.FailNow() | |||
| } | |||
| assert.Equal(t, http.StatusBadGateway, resp.StatusCode) | |||
| if !assert.Equal(t, http.StatusBadRequest, resp.StatusCode) { | |||
There was a problem hiding this comment.
This changed because of a change in the Go standard library.
hwh33
reviewed
May 31, 2019
| BufferPoolSize: 50 * 1024 * 1024, | ||
| }) | ||
| if err != nil { | ||
| log.Errorf("Error configuring packet forwarding: %v", err) |
There was a problem hiding this comment.
Why does this function not return an error? It seems like ListenAndServe (the caller) would want to know about this error and return it to its own caller.
I realize that this is not a change introduced by this PR. I just noticed it and was curious.
There was a problem hiding this comment.
I want the server to still be able to start and serve normal traffic even if this piece doesn't work.
hwh33
approved these changes
May 31, 2019
|
Thanks @hwh33! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For getlantern/lantern-internal#2791
Depends on: