Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(queue): allow retry more than 10 jobs #162

Merged
merged 1 commit into from
Mar 18, 2022
Merged

fix(queue): allow retry more than 10 jobs #162

merged 1 commit into from
Mar 18, 2022

Conversation

iam4x
Copy link
Contributor

@iam4x iam4x commented Feb 2, 2022 •
edited
Loading

Issue

Maximum number of entries per request are 10. You have sent 30.

image

Fix

  • AWS SQS allow batches of maximum 10 entries / messages
  • When retrying messages in dlq we should chunk messages in batch of 10

Output

image

@mnapoli mnapoli added the bug Something isn't working label Feb 5, 2022
mnapoli
mnapoli approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you that looks great!

Before I merge can you just confirm that this PR solved the bug for you?

@iam4x
Copy link
Contributor Author

iam4x commented Feb 11, 2022

Yes ser, if you have more than 10 failed jobs in the dlq the actual retry command won’t work.

@mnapoli
Copy link
Member

mnapoli commented Mar 18, 2022

Thank you!

@mnapoli mnapoli merged commit 2b4b3cd into getlift:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnapoli mnapoli mnapoli approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iam4x @mnapoli