Update cdk to v2 #193
Merged
Update cdk to v2 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to provision AWS Provider VPC configuration, reference to security group was made using securityGroupName property from Security Group CDK construct. This property is deprecated and was replaced with the use of securityGroupId which generate a different Cloudformation intrinsic function
t-richard
approved these changes
Apr 27, 2022
|
Thanks @mnapoli and @t-richard for your reviews. i however had to add an additional commit afterwards removing support for Node 12, as such node version is not supported by CDK v2. Do you agree with dropping support for Node 12 (end of life for Node 12 is due in 3 days -> https://nodejs.org/en/about/releases/) |
|
👍 sounds good! |
|
Seems fine to me too. Node 12 is EOL and most projects using Lift are probably recent projects using Node 14 already. |
|
Great, thanks for the feedbacks :). Merging and releasing with a changelog mentioning the summary of the BC above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades CDK from v1 to v2.
This considerably reduces the quantity of library in Lift dependencies. It also resolves L1 version conflict among various packages.
CDK migration guide was used to perform this upgrade.
The resulting dependencies includes :
aws-cdk-libfor all constructs librariesconstructsto be able to referenceConstructinterface@aws-cdk/aws-apigatewayv2-alpharequired for theWebhookconstruct in order to provision anHttpApi, which was already in alpha in CDK v1, and remains in alpha in CDK v2A few tests were adjusted to accommodate this update :
securityGroupNameproperty onSecurityGroupconstruct was deprecated in favor ofsecurityGroupId. This affects the generated Cloudformation intrinsic function used to reference such resource.TLSv1.2_2019toTLSv1.2_2021In addition, the new bootstrap version check enabled by CDK v2 was disabled implicitly following this guideline
AWS CDK v2 also removes support for node 10 and 12. Node 10 support was already removed from Lift, however this change will prevent users currently using Lift with node 12 to upgrade.