Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock_s3 raises wrong exception when versioning is enabled for a bucket #2710

Closed
ikonstantynov opened this issue Jan 30, 2020 · 1 comment · Fixed by #3532
Closed

mock_s3 raises wrong exception when versioning is enabled for a bucket #2710

ikonstantynov opened this issue Jan 30, 2020 · 1 comment · Fixed by #3532
Labels
enhancement

Comments

@ikonstantynov
Copy link

Hi there,

I'm testing some method that calls get_object method from boto3.client('s3'). There is a VersioningConfiguration enabled for a bucket that I'm trying to get a file from.
When I try to test a case where there is no such version for a given file, I'm receiving the wrong error code from moto.

Originally, s3 returns me a response with a response error code = NoSuchVersion while moto is always returning NoSuchKey error code.

Can this NoSuchVersion exception be added?
bblommers added a commit to bblommers/moto that referenced this issue Dec 9, 2020
@bblommers
getmoto#2710 - S3 - Raise specific error when GetObject is called wit…
6cde20b 
…h unknown VersionId
@bblommers bblommers mentioned this issue Dec 9, 2020
Merged
bblommers added a commit that referenced this issue Jan 13, 2021
@bblommers
#2710 - S3 - Raise specific error when GetObject is called with unkno…
d1696a3 
…wn VersionId (#3532)
@bblommers
Copy link
Collaborator

This should now be fixed as of moto >= 1.3.16.dev200

@amarjandu amarjandu mentioned this issue Apr 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise specific error when GetObject is called with unknown VersionId bblommers/moto
2 participants
@bblommers @ikonstantynov