Lock Flask #3925
Merged
Lock Flask #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch @guiscaranse - thanks for creating the PR |
bblommers
approved these changes
May 12, 2021
|
This is now part of moto >= 2.0.8.dev2 |
bblommers
added a commit
to bblommers/moto
that referenced
this pull request
May 13, 2021
This reverts commit 8bb0feb.
bblommers
added a commit
that referenced
this pull request
May 13, 2021
* Dont fail if CodeCov fails - for now * CI - Force cache rebuild * Bump werkzeug to latest version * CI - Enforce cache flush * ManagedBlockchain - fix error format * ManagedBlockchain - Fix tests to use pytest.raises paradigm * Revert "Lock Flask (#3925)" This reverts commit 8bb0feb. * CI - Enforce cache rebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3922 and #3921. Pinning only Werkzeug doesn't solve the issue since sometimes flask dependency might be installed first creating an impossible lock state when using tools like Pipenv.
This is a temporary fix until this project upgrades to Flask 2