Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Werkzeug 2.0.0 breaks tests #3921

Closed
bblommers opened this issue May 12, 2021 · 2 comments · Fixed by #3923
Closed

Werkzeug 2.0.0 breaks tests #3921

bblommers opened this issue May 12, 2021 · 2 comments · Fixed by #3923

Comments

@bblommers
Copy link
Collaborator

bblommers commented May 12, 2021

The S3 server test test_s3_server_post_without_content_length no longer works with werkzeug 2.0.0, as the calls return a 200 instead of a 411.

I'm submitting a PR to downgrade werkzeug for now, back to the known working version 1.0.1, until we have a solution.

@bblommers
Copy link
Collaborator Author

Werkzeug was downgraded as part of #3920

@bblommers
Copy link
Collaborator Author

bblommers commented May 12, 2021

The failing test was a red herring, caused by a mismatch in flask/werkzeug versions. Our CI cached flask to 1.x, but upgraded werkzeug to 2.x, (or vice versa.. I forgot) and they don't mix'n'match very well.

When upgrading both to 2.x, most of the tests work. The only thing failing is the exception handling in the managedblockchain service. This was always handled badly, but didn't break until the werkzeug upgrade.

I'm rewriting the exception handling now - TBC..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant