Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CognitoIdp fixes #4518

Merged
merged 7 commits into from
Mar 10, 2022
Merged

CognitoIdp fixes #4518

merged 7 commits into from
Mar 10, 2022

Conversation

mianowski
Copy link
Contributor

  • TokenType added to "AuthenticationResult"
  • Username corrected in ChalengeParameters

mianowski and others added 2 commits August 23, 2021 18:05
* TokenType added to "AuthenticationResult"
* Username corrected in ChalengeParameters
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mianowski, welcome to Moto!
Would you mind adding some assertions for this? Probably easiest to just add to one of the existing tests here, considering they're quite small changes.

Looks like the linting is failing on our CI as well - you can run make lint to verify this locally.
If black has an issue with the code, make sure that you have the right version (black==19.10b0), as different versions will have different formatting rules.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #4518 (333b5dc) into master (9dccebc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4518   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files         618      618           
  Lines       65481    65481           
=======================================
  Hits        62562    62562           
  Misses       2919     2919           
Flag Coverage Δ
servertests 36.11% <ø> (ø)
unittests 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/cognitoidp/models.py 94.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dccebc...333b5dc. Read the comment docs.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @mianowski. Happy to merge if we can get the CI to pass

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @mianowski!

@bblommers bblommers merged commit a4f58f0 into getmoto:master Mar 10, 2022
@bblommers bblommers added this to the 3.1.0 milestone Mar 10, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.0.dev5

sahilshah6196 pushed a commit to EBSCOIS/moto that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants