Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart upload support #64

Merged
merged 21 commits into from
Nov 23, 2013
Merged

Multipart upload support #64

merged 21 commits into from
Nov 23, 2013

Conversation

kouk
Copy link
Collaborator

@kouk kouk commented Nov 14, 2013

Fixes #7

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.29%) when pulling 3628e40 on kouk:master into d5b3af2 on spulec:master.

@kouk
Copy link
Collaborator Author

kouk commented Nov 14, 2013

hmm I see there's a problem with python 2.6 in the travis builds..

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) when pulling bdf5a9e on kouk:master into d5b3af2 on spulec:master.

@spulec
Copy link
Collaborator

spulec commented Nov 15, 2013

This is awesome! Thank you all for your work.

I'm going to do a quick review, but hopefully we can get this merged soon.

def __init__(self, key_name):
self.key_name = key_name
self.parts = {}
self.id = base64.b64encode(os.urandom(43)).replace('=', '').replace('+', '')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make 43 a constant.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) when pulling 85e3210 on kouk:master into d5b3af2 on spulec:master.

spulec added a commit that referenced this pull request Nov 23, 2013
Multipart upload support
@spulec spulec merged commit 4853954 into getmoto:master Nov 23, 2013
@spulec
Copy link
Collaborator

spulec commented Nov 23, 2013

Great. Thanks everyone!

I'll hopefully push out a new release this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Multipart Uploads
5 participants