Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELBv2: fix parity in describe_target_group #6812

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

macnev2013
Copy link
Contributor

Motivation

This PR fixes minor parity gaps with aws in describe_target_groups api

Fixed

  • sorting the list of target group before returning it
  • multiple arguments in describe call raises an exception

Added

  • Added test cases for describe_target_groups api

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #6812 (2216c4a) into master (c1a6609) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #6812      +/-   ##
==========================================
- Coverage   96.20%   96.20%   -0.01%     
==========================================
  Files         816      816              
  Lines       80009    80022      +13     
==========================================
+ Hits        76973    76984      +11     
- Misses       3036     3038       +2     
Flag Coverage Δ
servertests 37.01% <11.11%> (-0.01%) ⬇️
unittests 96.14% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
moto/elbv2/responses.py 99.44% <ø> (ø)
moto/elbv2/models.py 92.65% <75.00%> (-0.12%) ⬇️
moto/elbv2/exceptions.py 90.00% <100.00%> (ø)

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bblommers bblommers added this to the 4.2.3 milestone Sep 15, 2023
@bblommers bblommers changed the title fix parity in describe_target_group ELBv2: fix parity in describe_target_group Sep 15, 2023
@bblommers bblommers merged commit 971e432 into getmoto:master Sep 15, 2023
81 of 82 checks passed
toshyak pushed a commit to toshyak/moto that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants