APIGateway: Refactor request handling #7626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
added
the
moto-core
bblommers
force-pushed
the
apigateway/refactor-request-dispatching
branch
5 times, most recently
from
738bb45
to
650d01e
Compare
bblommers
force-pushed
the
apigateway/refactor-request-dispatching
branch
from
650d01e
to
2bc1d1c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7626 +/- ##
==========================================
- Coverage 95.88% 94.26% -1.62%
==========================================
Files 843 1072 +229
Lines 82578 92188 +9610
==========================================
+ Hits 79178 86899 +7721
- Misses 3400 5289 +1889
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This is now part of moto >= 5.0.6.dev34 |
This was referenced Apr 25, 2024
jfmainville
pushed a commit
to jfmainville/moto
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the manual request dispatching where possible, and just let the
dispatch-method handle this.This PR just adds tests for
(un)tag_resource, as the functionality already existed