Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: Refactor Route53 responses #7632

Merged

Conversation

bblommers
Copy link
Collaborator

See #7626

@bblommers bblommers added the moto-core PR's that touch the core functionality. This will trigger additional tests. label Apr 25, 2024
@bblommers bblommers added this to the 5.0.6 milestone Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (9aef694) to head (b28570f).
Report is 205 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7632      +/-   ##
==========================================
- Coverage   95.88%   94.25%   -1.63%     
==========================================
  Files         843     1072     +229     
  Lines       82578    91889    +9311     
==========================================
+ Hits        79178    86611    +7433     
- Misses       3400     5278    +1878     
Flag Coverage Δ
servertests 29.53% <39.18%> (-3.00%) ⬇️
unittests 94.22% <100.00%> (-1.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit b10de22 into getmoto:master Apr 25, 2024
76 of 77 checks passed
@bblommers bblommers deleted the techdebt/route53-request-handling branch April 25, 2024 21:42
Copy link
Contributor

This is now part of moto >= 5.0.6.dev37

jfmainville pushed a commit to jfmainville/moto that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant