Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up listeners on PIE session #23

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Cleaning up listeners on PIE session #23

merged 1 commit into from
Feb 21, 2023

Conversation

reisandbeans
Copy link
Contributor

No description provided.

@getnamo
Copy link
Owner

getnamo commented Nov 3, 2021

Interesting approach, I wonder if the begin pie lambda gets called before other e.g. actor begin play calls? If so that small change might be enough. Have you tested this with a bunch of listener adds on begin play?

@Tokix
Copy link

Tokix commented Feb 21, 2023

Can confirm that this PR is working. Before UE (5.1 in my case) crashed on fast restarts within the editor with multiple listeners. The old references of listeners were not cleaned up propertly as the GESWorldListenerActor which is responsible for the cleanup does not exist right at the beginning it takes some time to spawn. So If the application is closed before this actor exists the listeners do not get cleaned up leading to crashes within the UE-Editor "Play of selected Viewport", because the GES Plugin still keeps this references over the restarts of the game within the UE-Editor. With this version its not crashing and working as expected.

@getnamo
Copy link
Owner

getnamo commented Feb 21, 2023

Thanks for the detailed response. I want to probably refactor some of the logic to use a world subsystem instead, but this is a good backup either way it seems.

@getnamo getnamo merged commit f15a572 into getnamo:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants