Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all users have names #187

Merged
merged 5 commits into from
Dec 13, 2018
Merged

Not all users have names #187

merged 5 commits into from
Dec 13, 2018

Conversation

timperrett
Copy link
Member

@timperrett timperrett commented Dec 13, 2018

resolves #186

im-a-spy-5a96f6

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e24c0ee). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #187   +/-   ##
=========================================
  Coverage          ?   55.51%           
=========================================
  Files             ?      132           
  Lines             ?     4354           
  Branches          ?      113           
=========================================
  Hits              ?     2417           
  Misses            ?     1937           
  Partials          ?        0
Impacted Files Coverage Δ
core/src/main/scala/Github.scala 22.68% <ø> (ø)
core/src/main/scala/Session.scala 92.85% <ø> (ø)
core/src/main/scala/User.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24c0ee...7ea1b13. Read the comment docs.

Copy link
Member

@adelbertc adelbertc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cute 🐱 picture, approved by default

@timperrett timperrett merged commit 1f99236 into getnelson:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github users do not require a name, but Nelson presently requires it
3 participants