Have the ability to specify an ELB as internal #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @adelbertc @goedelsoup |
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=========================================
Coverage ? 55.57%
=========================================
Files ? 133
Lines ? 4383
Branches ? 112
=========================================
Hits ? 2436
Misses ? 1947
Partials ? 0
Continue to review full report at Codecov.
|
goedelsoup
approved these changes
Feb 27, 2019
goedelsoup
pushed a commit
to goedelsoup/nelson
that referenced
this pull request
Apr 1, 2019
* master: Expose unit name as env var (getnelson#225) Check the default elb scheme takes effect (getnelson#224) fix typos (getnelson#222) Use multiple branches Fix bug where the 'only' filter of DC targets was not being parsed (getnelson#220) LB name error message should be dynamic length (getnelson#217) Have the ability to specify an ELB as internal (getnelson#216) Fix LB naming to match the validators expectations (getnelson#215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify that the ELB that nelson launches is
internal. For more information see: https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-internal-load-balancers.html