Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin name not being correctly accessed #3555

Open
vsajip opened this issue Jun 12, 2021 · 0 comments
Open

Plugin name not being correctly accessed #3555

vsajip opened this issue Jun 12, 2021 · 0 comments

Comments

@vsajip
Copy link

vsajip commented Jun 12, 2021

The name specified for a plugin seems not to be correctly accessed - it's not being read from the plugin_info's plugin_object, as it ought to be. Instead of

self._commands[plugin_info.name] = plugin_info.plugin_object

it should be something like

          name = getattr(plugin_info.plugin_object, 'name', plugin_info.name)
          self._commands[name] = plugin_info.plugin_object

Similar logic needs to be applied for the activation, at

self.plugin_manager.activatePluginByName(plugin_info.name)

which could be something like

          name = getattr(plugin_info.plugin_object, 'name', plugin_info.name)
          self.plugin_manager.activatePluginByName(name)
vsajip added a commit to vsajip/nikola that referenced this issue Aug 9, 2021
vsajip added a commit to vsajip/nikola that referenced this issue Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant