Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site menu (don’t escape HTML in navbar) #2103

Merged
merged 4 commits into from Sep 21, 2015
Merged

Fix site menu (don’t escape HTML in navbar) #2103

merged 4 commits into from Sep 21, 2015

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Sep 20, 2015

This fixes the getnikola.com site menu by not escaping things in the navbar.

I also added one missing escape. However, we could debate doing it for some places that also could use formatting, such as:

  • post titles (?)
  • tag and author descriptions (which are long-form fields — makes a lot of sense)

Comments?

Kwpolska added 2 commits Sep 20, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska self-assigned this Sep 20, 2015
@Kwpolska Kwpolska added this to the 7.7.2 milestone Sep 20, 2015
Kwpolska added 2 commits Sep 20, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Kwpolska added a commit that referenced this issue Sep 21, 2015
Fix site menu (don’t escape HTML in navbar)
@Kwpolska Kwpolska merged commit d41be89 into master Sep 21, 2015
3 checks passed
@Kwpolska Kwpolska deleted the fix-site-menu branch Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant