Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass positional arguments to template-based shortcodes #2320

Merged
merged 1 commit into from Apr 19, 2016

Conversation

@SpotlightKid
Copy link
Contributor

SpotlightKid commented Apr 18, 2016

Implements #2319. See rationale there.

Signed-off-by: Christopher Arndt chris@chrisarndt.de

)

Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@felixfontein
Copy link
Contributor

felixfontein commented Apr 19, 2016

The test failures are because Nikola couldn't download a gist. The changes LGTM and their tests don't fail.

@ralsina
Copy link
Member

ralsina commented Apr 19, 2016

LGTM

@ralsina ralsina merged commit 71116f3 into getnikola:master Apr 19, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@SpotlightKid SpotlightKid deleted the SpotlightKid:feature/issue-2319 branch Apr 19, 2016
@SpotlightKid
Copy link
Contributor Author

SpotlightKid commented Apr 19, 2016

Should I make a PR for AUTHORS.txt, CHANGES.txt and the docs as well?

@Kwpolska
Copy link
Member

Kwpolska commented Apr 19, 2016

Go ahead.

Kwpolska added a commit that referenced this pull request Apr 20, 2016
Update AUTHORS.txt, CHANGES.txt and docs according to #2320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.