Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved EXIF orientation handling #2395

Merged
merged 2 commits into from Jul 18, 2016
Merged

Improved EXIF orientation handling #2395

merged 2 commits into from Jul 18, 2016

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jul 18, 2016

Improve EXIF orientation handling according to http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/

To test IRL, get the test images, put them in a gallery, set PRESERVE_EXIF to True and it should work well.

ralsina added 2 commits Jul 18, 2016
@ralsina ralsina merged commit b3f8579 into master Jul 18, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the improve-exif-orientation branch Jul 18, 2016
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 18, 2016

Do we need an extra dependency for this? Or maybe we could vendor it in?

@ralsina
Copy link
Member Author

@ralsina ralsina commented Jul 18, 2016

Sadly, yes, because Pillow's support for EXIF is lame. It's a pure-python
dependency, so it should not be much of a problem. We could vendor it in,
yes.

On Mon, Jul 18, 2016 at 3:19 PM Chris Warrick notifications@github.com
wrote:

Do we need an extra dependency for this? Or maybe we could vendor it in?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#2395 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAGKweJUkMFkU-1aQtImKSId834Vk2Qks5qW8OrgaJpZM4JO5Lq
.

@ralsina
Copy link
Member Author

@ralsina ralsina commented Jul 18, 2016

This fix would not be worth it, but the upcoming exif filtering feature
makes it worth it, if nothing else for privacy reasons.

On Mon, Jul 18, 2016 at 3:29 PM Roberto Alsina ralsina@kde.org wrote:

Sadly, yes, because Pillow's support for EXIF is lame. It's a pure-python
dependency, so it should not be much of a problem. We could vendor it in,
yes.

On Mon, Jul 18, 2016 at 3:19 PM Chris Warrick notifications@github.com
wrote:

Do we need an extra dependency for this? Or maybe we could vendor it in?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#2395 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAGKweJUkMFkU-1aQtImKSId834Vk2Qks5qW8OrgaJpZM4JO5Lq
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants