Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove googleplus comments #2966

Merged
merged 1 commit into from
Feb 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ Bugfixes
Removed features
----------------

* Removed ``googleplus`` comments (no longer supported) (Issue #635)
* Removed the slides directive for docutils, it will now be a separate plugin.
* Dropped Python 2 and Python 3.3 support (oldest supported version is 3.4)
* Removed ``nikola install_theme`` — use ``nikola theme`` instead
Expand Down
5 changes: 1 addition & 4 deletions docs/manual.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1741,13 +1741,11 @@ Nikola supports several third party comment systems:
* `IntenseDebate <http://www.intensedebate.com/>`_
* `LiveFyre <http://www.livefyre.com/>`_
* `Moot <http://moot.it>`_
* `Google+ <http://plus.google.com>`_
* `Facebook <http://facebook.com/>`_
* `isso <http://posativ.org/isso/>`_

By default it will use DISQUS, but you can change by setting ``COMMENT_SYSTEM``
to one of "disqus", "intensedebate", "livefyre", "moot", "googleplus",
"facebook" or "isso"
to one of "disqus", "intensedebate", "livefyre", "moot", "facebook" or "isso"

.. sidebar:: ``COMMENT_SYSTEM_ID``

Expand All @@ -1758,7 +1756,6 @@ to one of "disqus", "intensedebate", "livefyre", "moot", "googleplus",
* In IntenseDebate it's the **IntenseDebate site acct**
* In LiveFyre it's the **siteId**
* In Moot it's your **username**
* For Google Plus, ``COMMENT_SYSTEM_ID`` need not be set. WARNING: this will not work correctly in the test server, needs to be deployed to a real server/URL.
* For Facebook, you need to `create an app
<https://developers.facebook.com/apps>`_ (turn off sandbox mode!)
and get an **App ID**
Expand Down
7 changes: 0 additions & 7 deletions nikola/data/themes/base-jinja/templates/comments_helper.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
{% import 'comments_helper_livefyre.tmpl' as livefyre with context %}
{% import 'comments_helper_intensedebate.tmpl' as intensedebate with context %}
{% import 'comments_helper_muut.tmpl' as muut with context %}
{% import 'comments_helper_googleplus.tmpl' as googleplus with context %}
{% import 'comments_helper_facebook.tmpl' as facebook with context %}
{% import 'comments_helper_isso.tmpl' as isso with context %}

Expand All @@ -17,8 +16,6 @@
{{ intensedebate.comment_form(url, title, identifier) }}
{% elif comment_system == 'muut' %}
{{ muut.comment_form(url, title, identifier) }}
{% elif comment_system == 'googleplus' %}
{{ googleplus.comment_form(url, title, identifier) }}
{% elif comment_system == 'facebook' %}
{{ facebook.comment_form(url, title, identifier) }}
{% elif comment_system == 'isso' %}
Expand All @@ -35,8 +32,6 @@
{{ intensedebate.comment_link(link, identifier) }}
{% elif comment_system == 'muut' %}
{{ muut.comment_link(link, identifier) }}
{% elif comment_system == 'googleplus' %}
{{ googleplus.comment_link(link, identifier) }}
{% elif comment_system == 'facebook' %}
{{ facebook.comment_link(link, identifier) }}
{% elif comment_system == 'isso' %}
Expand All @@ -53,8 +48,6 @@
{{ intensedebate.comment_link_script() }}
{% elif comment_system == 'muut' %}
{{ muut.comment_link_script() }}
{% elif comment_system == 'googleplus' %}
{{ googleplus.comment_link_script() }}
{% elif comment_system == 'facebook' %}
{{ facebook.comment_link_script() }}
{% elif comment_system == 'isso' %}
Expand Down

This file was deleted.

7 changes: 0 additions & 7 deletions nikola/data/themes/base/templates/comments_helper.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<%namespace name="livefyre" file="comments_helper_livefyre.tmpl"/>
<%namespace name="intensedebate" file="comments_helper_intensedebate.tmpl"/>
<%namespace name="muut" file="comments_helper_muut.tmpl"/>
<%namespace name="googleplus" file="comments_helper_googleplus.tmpl"/>
<%namespace name="facebook" file="comments_helper_facebook.tmpl"/>
<%namespace name="isso" file="comments_helper_isso.tmpl"/>

Expand All @@ -17,8 +16,6 @@
${intensedebate.comment_form(url, title, identifier)}
% elif comment_system == 'muut':
${muut.comment_form(url, title, identifier)}
% elif comment_system == 'googleplus':
${googleplus.comment_form(url, title, identifier)}
% elif comment_system == 'facebook':
${facebook.comment_form(url, title, identifier)}
% elif comment_system == 'isso':
Expand All @@ -35,8 +32,6 @@
${intensedebate.comment_link(link, identifier)}
% elif comment_system == 'muut':
${muut.comment_link(link, identifier)}
% elif comment_system == 'googleplus':
${googleplus.comment_link(link, identifier)}
% elif comment_system == 'facebook':
${facebook.comment_link(link, identifier)}
% elif comment_system == 'isso':
Expand All @@ -53,8 +48,6 @@
${intensedebate.comment_link_script()}
% elif comment_system == 'muut':
${muut.comment_link_script()}
% elif comment_system == 'googleplus':
${googleplus.comment_link_script()}
% elif comment_system == 'facebook':
${facebook.comment_link_script()}
% elif comment_system == 'isso':
Expand Down
17 changes: 0 additions & 17 deletions nikola/data/themes/base/templates/comments_helper_googleplus.tmpl

This file was deleted.

3 changes: 1 addition & 2 deletions nikola/nikola.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,11 @@

__all__ = ('Nikola',)

# We store legal values for some setting here. For internal use.
# We store legal values for some settings here. For internal use.
LEGAL_VALUES = {
'COMMENT_SYSTEM': [
'disqus',
'facebook',
'googleplus',
'intensedebate',
'isso',
'livefyre',
Expand Down
2 changes: 1 addition & 1 deletion tests/data/translated_titles/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@

# To use comments, you can choose between different third party comment
# systems, one of "disqus", "livefyre", "intensedebate", "moot",
# "googleplus", "facebook" or "isso"
# "facebook" or "isso"
COMMENT_SYSTEM = "disqus"
# And you also need to add your COMMENT_SYSTEM_ID which
# depends on what comment system you use. The default is
Expand Down