Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial implementation of #2970, untested #2990

Merged
merged 5 commits into from Apr 5, 2018
Merged

Conversation

@ralsina
Copy link
Member

ralsina commented Mar 17, 2018

Adds a new MARKDOWN_EXTENSION_CONFIGS translatable option, which is passed as-is to python markdown

Totally untested yet.

@@ -89,8 +90,12 @@ def set_site(self, site):
site_extensions = self.site.config.get("MARKDOWN_EXTENSIONS")
self.config_dependencies.append(str(sorted(site_extensions)))
extensions.extend(site_extensions)

site_extension_configs = self.site.config.get("MARKDOWN_EXTENSION_CONFIGS", {})
self.config_dependencies.append(json.dumps(site_extension_configs, sort_keys=True))

This comment has been minimized.

@Kwpolska

Kwpolska Mar 17, 2018 Member

Does it actually work like this, without actually calling the translatable setting?

This comment has been minimized.

@ralsina

ralsina Mar 17, 2018 Author Member

Forget it, this approach is totally broken. Looks like we need one markdown converter per-language.

@ralsina ralsina changed the title Initial implementation of #2970, untested [WIP] Initial implementation of #2970, untested Mar 17, 2018
ralsina added 3 commits Mar 18, 2018
@ralsina ralsina merged commit 86525ea into master Apr 5, 2018
0 of 5 checks passed
0 of 5 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ralsina ralsina deleted the pymarkdown_options branch Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.