Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery: use JS appendChild instead of append #3096

Merged
merged 1 commit into from May 22, 2018

Conversation

@evetsso
Copy link
Contributor

@evetsso evetsso commented May 22, 2018

It's only appending one child anyway, and append is not supported (yet?) by
IE and Edge.

Fixes #3095.

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Hopefully self-explanatory. The Disqus JS appears to already by calling appendChild too.

It's only appending one child anyway, and append is not supported (yet?) by
IE and Edge.

Fixes #3095.
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 22, 2018

Sigh, why is IE still a thing?

@Kwpolska Kwpolska merged commit 5753f59 into getnikola:master May 22, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@evetsso evetsso deleted the evetsso:gallery-ie-edge-fix branch May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.