Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3198 -- make Commento comments work #3199

Merged
merged 3 commits into from
Feb 5, 2019
Merged

Fix #3198 -- make Commento comments work #3199

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c53262
Fix #3198 -- make Commento comments work
Kwpolska Jan 3, 2019
107c65e
Fix Commento for real
Kwpolska Jan 7, 2019
c164358
Merge branch 'master' into fix-commento
ralsina Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ New in master
Bugfixes
--------

* Make Commento comments work (Issue #3198)
* Set one-file status basing on default language only (Issue #3191)
* Don’t warn if post status is set to ``published`` explicitly
(Issue #3181)
Expand Down
11 changes: 2 additions & 9 deletions nikola/data/themes/base-jinja/templates/comments_helper_commento.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
{# -*- coding: utf-8 -*- #}
{% macro comment_form(url, title, identifier) %}
<div id="commento"></div>

<script defer src="{{ comment_system_id }}/js/commento.js"></script>
{% endmacro %}

{% macro comment_link(link, identifier) %}
{% endmacro %}


{% macro comment_link_script() %}
<script src="{{ comment_system_id }}/assets/js/commento.min.js"></script>
<script>
window.onload = function() {
Commento.init({
serverUrl: "{{ comment_system_id }}",
});
}
</script>
{% endmacro %}
11 changes: 2 additions & 9 deletions nikola/data/themes/base/templates/comments_helper_commento.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
## -*- coding: utf-8 -*-
<%def name="comment_form(url, title, identifier)">
<div id="commento"></div>

<script defer src="${comment_system_id}/js/commento.min.js"></script>
</%def>

<%def name="comment_link(link, identifier)">
</%def>


<%def name="comment_link_script()">
<script src="${comment_system_id}/assets/js/commento.min.js"></script>
<script>
window.onload = function() {
Commento.init({
serverUrl: "${comment_system_id}",
});
}
</script>
</%def>