Fix qtranslate-x import #3275
Merged
Fix qtranslate-x import #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concerns image attachment medata and I observed the bug for old french posts of mine => an exception occured because floats were saved and exported with a ',' instead of a '.'
This fixes wordpress import error when there are translations. - The "context" provided to get the translation candidate was the context to generate the config file and not the actual dictionary of options (resulting in TRANSLATIONS being a string instead of the expected dict) - If user forgot to provide one (with the qtranslate mode), the import would fail for not finding any key 'TRANSLATIONS_PATTERN'.
This supports "up to" qtranslateX format for translations. It also allows to recover the titles' translation on the condition that the wordpress exports is made with the following specific hack taken from qtranslate/qtranslate-xt#199 : ``` In wp-admin/includes/export.php change `echo apply_filters( 'the_title_rss', $post->post_title ); to `echo apply_filters( 'the_title_export', $post->post_title ); ```
|
Please fix |
Sure, sorry for missing those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Make the import of an old wordpress blog with content generate from various generations (yes "generations"... :) ) of qtranslate plugins work smoother. Including the ability to recover translation titles (provided that the user does a little bit of hacking on wordpress side as docummented here)