Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data file to dependency file #3609

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

everlanes
Copy link
Contributor

When using a data attribute for loading external data from a file, this data
file is added to the dependency file.
Changing the content of the data file now triggers a rebuild of the pages and
posts which are including it.

Signed-off-by: Andreas Brinner andreas@everlanes.net

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

I tested with my own site and confirmed that the dependencies were added correctly.

When using a data attribute for loading external data from a file, this data
file is added to the dependency file.
Changing the content of the data file now triggers a rebuild of the pages and
posts which are including it.

fix getnikola#3608

Signed-off-by: Andreas Brinner <andreas@everlanes.net>
@Kwpolska Kwpolska enabled auto-merge April 14, 2022 19:24
@Kwpolska Kwpolska linked an issue Apr 14, 2022 that may be closed by this pull request
@Kwpolska Kwpolska merged commit a26b21f into getnikola:master Apr 14, 2022
@Kwpolska
Copy link
Member

Thanks for contributing this fix!

@everlanes everlanes deleted the add_data_file_dependency branch April 14, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data files are not tracked as dependencies
2 participants