Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bootswatch_theme command #664

Merged
merged 1 commit into from
Sep 7, 2013

Conversation

areski
Copy link
Member

@areski areski commented Sep 7, 2013

Command bootswatch_theme is now fixed for bootstrap3 and boostrap2

@Kwpolska Kwpolska merged commit d8afb2a into getnikola:master Sep 7, 2013
@Kwpolska
Copy link
Member

Kwpolska commented Sep 7, 2013

You have commit rights, why not do it yourself on this repo?

Also, bootstrap 2 is the default theme right now.

@areski
Copy link
Member Author

areski commented Sep 7, 2013

I can press the merge button, I know... but opening it, it's a nice way to discuss it before merging.
I'm being cautious for the moment, but things that are straightforward I will commit directly.

Yes bootstrap2 is default for nikola, but bootstrap3 is default for bootswatch

@ralsina
Copy link
Member

ralsina commented Sep 7, 2013

I don't quite see the point of this change. It doesn't seem to hurt anything either, tho, so... ok! :-)

@areski
Copy link
Member Author

areski commented Sep 7, 2013

@ralsina
The important part is:

-            'default': 'site',
-            'help': 'Parent theme name (default: site)',
+            'default': 'bootstrap3',
+            'help': 'Parent theme name (default: bootstrap3)',

'site' doesnt' exist anymore

Kwpolska added a commit that referenced this pull request Sep 7, 2013
@ralsina
Copy link
Member

ralsina commented Sep 7, 2013

@areski Ah, good catch there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants