Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irclogs clickable links #80

Merged
merged 1 commit into from May 16, 2015
Merged

irclogs clickable links #80

merged 1 commit into from May 16, 2015

Conversation

@da2x
Copy link
Contributor

da2x commented May 15, 2015

The links are untrusted, so nofollow.

cc/@Kwpolska

The links are untrusted, so nofollow.
Kwpolska added a commit that referenced this pull request May 16, 2015
irclogs clickable links
@Kwpolska Kwpolska merged commit 51968d7 into master May 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the irclogs-linker branch May 16, 2015
@Kwpolska Kwpolska restored the irclogs-linker branch May 16, 2015
@Kwpolska
Copy link
Member

Kwpolska commented May 16, 2015

Merged a bit too fast, it looks like it’s not done correctly…

<pre class="code literal-block"><a name="irclog-1"></a><span class="cp">21:47:48 </span><span class="nt">&lt;Aeyoun&gt; </span>why isnt the "Suggested configuration" section shown? <a href="https://plugins.getnikola.com/#recent_posts_json%0A&lt;a" rel="nofollow">https://plugins.getnikola.com/#recent_posts_json
</a><a> name="irclog-2"&gt;</a><span class="cp">21:59:01 </span><span class="nt">&lt;Aeyoun&gt; </span>Fixed! :) <a href="https://www.google.no/search?q=site:plugins.getnikola.com%0A&lt;a" rel="nofollow">https://www.google.no/search?q=site:plugins.getnikola.com
@Kwpolska
Copy link
Member

Kwpolska commented May 16, 2015

fixed by matching against all whitespace: [^\s]+

@Kwpolska Kwpolska deleted the irclogs-linker branch May 16, 2015
@da2x
Copy link
Contributor Author

da2x commented May 16, 2015

Broke on links ending with a line ending? Of course. Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.