This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Fix test compile #192
Merged
Fix test compile #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix-test-compile
|
Cool. I’ll look right now. |
dcbriccetti
approved these changes
Sep 12, 2017
lognaturel
approved these changes
Sep 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172 and uses latest version of mockito for consistency.
What has been done to verify that this works as intended?
Ran
./gradlew clean testand confirmed there were test reports.Ran
./gradlew clean runand confirmed the application ran.Ran
./gradlew clean jarand double clicked the jar and confirmed the application ran.Why is this the best possible solution? Were any other approaches considered?
I found the idea for this solution at https://stackoverflow.com/a/15029935/152938. I believe java.srcDirs is where gradle looks for non-test code. If tests are inside that folder, it causes classpath problems. We could change java.srcDirs to
src/orgbut then we have to add to that array if we have code that doesn't start with org. Seems easier to move the test folder to where gradle expects it.And as a pleasant side effect, the binary has gone from 11 MB to 7 MB.
Are there any risks to merging this code? If so, what are they?
Not really. But please squash before merging.