This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Improve data sent to analytics to track it more easily #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having trouble verifying that the usage information was being sent to GA, mainly because we weren't filling some fields that one would normally fill if the app was a website (following the recommendation on the GA manuals).
This PR sets the document path and title to the tab the user opens to trick GA into thinking that the app is a website. This improves a lot the information available on GA about Briefcase usage.
Previously we were even having trouble seen realtime usage information, which on this PR seems to work better.
What has been done to verify that this works as intended?
Manually launched Briefcase and verified on GA that we are sending data.
Why is this the best possible solution? Were any other approaches considered?
No other option for the moment.
Are there any risks to merging this code? If so, what are they?
Nope
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope