Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Improve data sent to analytics to track it more easily #515

Merged
merged 1 commit into from Jun 7, 2018
Merged

Improve data sent to analytics to track it more easily #515

merged 1 commit into from Jun 7, 2018

Conversation

ggalmazor
Copy link
Contributor

We were having trouble verifying that the usage information was being sent to GA, mainly because we weren't filling some fields that one would normally fill if the app was a website (following the recommendation on the GA manuals).

This PR sets the document path and title to the tab the user opens to trick GA into thinking that the app is a website. This improves a lot the information available on GA about Briefcase usage.

Previously we were even having trouble seen realtime usage information, which on this PR seems to work better.

What has been done to verify that this works as intended?

Manually launched Briefcase and verified on GA that we are sending data.

Why is this the best possible solution? Were any other approaches considered?

No other option for the moment.

Are there any risks to merging this code? If so, what are they?

Nope

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope

@dcbriccetti dcbriccetti merged commit ca75035 into getodk:master Jun 7, 2018
@ggalmazor ggalmazor deleted the improve_usage_tracking branch June 7, 2018 18:17
@kkrawczyk123
Copy link
Contributor

@ggalmazor None of my actions pull/push/export from all three operating systems were tracked on google analytics in real time events.
@opendatakit-bot unlabel "needs testing"

@ggalmazor
Copy link
Contributor Author

ggalmazor commented Jun 11, 2018

@kkrawczyk123 I can see all my tab changes real-time... Can you check again, please? Bear in mind that it has some delay and that the real-time dashboard is not 100% reliable.

pr_515

The most reliable dashboard to verify that GA integration works is the one that lists visited pages per version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants