This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Fix (recover) missing pull/push/export operation GA events #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkrawczyk123, this PR fixes sending the events on GA when pulling/pushing/exporting forms. |
|
Verified on Ubuntu, MacOS and Windows with success! |
lognaturel
approved these changes
Jun 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
Manually pulled/pushed/exported forms to see event hits in the realtime report in GA
Why is this the best possible solution? Were any other approaches considered?
This is just some code that was missed during some merge conflict resolution
Are there any risks to merging this code? If so, what are they?
Nope.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.