This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Exclude draft form definitions from Central list #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
============================================
- Coverage 48.33% 48.28% -0.05%
+ Complexity 1647 1645 -2
============================================
Files 195 195
Lines 10422 10423 +1
Branches 753 753
============================================
- Hits 5037 5033 -4
- Misses 5026 5029 +3
- Partials 359 361 +2
Continue to review full report at Codecov.
|
|
Tested with success! Tested cases:
@getodk-bot unlabel "needs testing" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #861
What has been done to verify that this works as intended?
Added a draft form definition to Central project, configured that project as a pull source, verified that the draft form didn't show up in the list.
Why is this the best possible solution? Were any other approaches considered?
This filters out drafts which is exactly what we want. I don't see any other possibilities.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just fix the bug. It's a one line change that's very targeted so should truly be very low risk.
Does this change require updates to documentation? If so, please file an issue at https://github.com/getodk/docs/issues/new and include the link below.
No.